Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Break up Irc() into a state tracker and a socket-based subclass #371

Closed
3 tasks done
jlu5 opened this issue Dec 10, 2016 · 0 comments
Closed
3 tasks done

Break up Irc() into a state tracker and a socket-based subclass #371

jlu5 opened this issue Dec 10, 2016 · 0 comments
Labels
involves: protocol spec involves changing the protocol spec type: enhancement improvements to existing features
Milestone

Comments

@jlu5
Copy link
Collaborator

jlu5 commented Dec 10, 2016

This would allow PyLink to establish virtual connections to non-IRC services (e.g. XMPP, Telegram)

  • Break up connect(), connect loop threading, disconnect(), run(), and send() into an IRC specific class
    • Depending on the framework we're hooking into, 3rd-party transports may choose to skip run() and send() entirely.
    • xmpppy has its own registerHandler(), for example
  • Call protocol specific disconnect code irc.proto.disconnect() if defined Split protocol specific and protocol agnostic connect/disconnect code
  • Move schedulePing() into this new (IRC-specific) class, and possibly allow turning ping checks off entirely
@jlu5 jlu5 added involves: api change breaking API changes type: enhancement improvements to existing features involves: protocol spec involves changing the protocol spec labels Dec 10, 2016
@jlu5 jlu5 mentioned this issue Dec 10, 2016
@jlu5 jlu5 added this to the v1.2 milestone May 12, 2017
@jlu5 jlu5 removed the involves: api change breaking API changes label Jun 16, 2017
@jlu5 jlu5 modified the milestones: v1.2, v2.0 Jun 30, 2017
@jlu5 jlu5 closed this as completed Jun 30, 2017
@poVoq poVoq mentioned this issue Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
involves: protocol spec involves changing the protocol spec type: enhancement improvements to existing features
Projects
No open projects
Enhanced protocol abstraction
Protocol API enhancements
Development

No branches or pull requests

1 participant