BF: AttributeMap -- consider only int (+unsigned) and float to be numeric labels #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eric labels This generalizes the logic and thus unicode labels would also be mapped, as well as any other odd type. Use unicode labels for normal_feature_dataset
Such scalars as np.unicode_ (or float128 until h5py 2.9.0) do not have direct representation in hdf5 and require special handling.
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
+ Coverage 75.77% 75.77% +<.01%
==========================================
Files 366 366
Lines 41914 41923 +9
Branches 6750 6753 +3
==========================================
+ Hits 31759 31766 +7
- Misses 8270 8273 +3
+ Partials 1885 1884 -1
Continue to review full report at Codecov.
|
|
I think the world will be a better place for PyMVPA after this ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the logic and thus unicode labels would also be mapped,
as well as any other odd type. Use unicode labels for normal_feature_dataset
Closes #604