Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cursor._executed before query() #283

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@methane
Copy link
Member

methane commented Nov 5, 2018

Fixes #282

@methane methane merged commit e7fddae into PyMySQL:master Nov 5, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@methane methane changed the title Clear cursor._query before query() Clear cursor._executed before query() Nov 5, 2018

@methane methane deleted the methane:clear-result branch Nov 5, 2018

@timgraham

This comment has been minimized.

Copy link

timgraham commented Dec 5, 2018

Hi, this change broke backwards compatibility with Django (https://github.com/django/django/blob/fbc7e4138921d0fbee823ce6ea9774de66d27e47/django/db/backends/mysql/operations.py#L144). Do you consider it an issue or should we adapt Django?

@methane

This comment has been minimized.

Copy link
Member Author

methane commented Dec 5, 2018

@timgraham Please use Cursor._executed instead. _last_executed is duplicate of _executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.