use file_name to get bindings manifest name #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
messense
reviewed
Oct 31, 2023
|
Sorry, I accidentally closed this by reference in a different PR |
|
The test failure on Windows is probably related to We can use path-slash crate to deal with that. |
messense
added
the
CI-no-fail-fast
messense
force-pushed
the
sdist-nested-workspace
branch
from
5cb7b0d
to
1e6d8d2
Compare
2 tasks
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 15, 2023
https://build.opensuse.org/request/show/1126453 by user mia + anag+factory - Update to 1.3.2 * Switch to Ruff formatter gh#PyO3/maturin#1817 * Upgrade ring to 0.17 gh#PyO3/maturin#1819 * Un-deprecate MATURIN_PEP517_ARGS env var gh#PyO3/maturin#1820 * Add support for uniffi library mode gh#PyO3/maturin#1729 * Fix missing member in Cargo.toml for sdist of nested workspace layout gh#PyO3/maturin#1828 * Metadata: escape display name in email addresses gh#PyO3/maturin#1832 * Fix rewriting workspace Cargo.toml in sdist gh#PyO3/maturin#1841 * Fix glob workspace members matching in sdist gh#PyO3/maturin#1846 * Add sdist tests for well-known downstream repositories gh#PyO3/maturin#1849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to update how the python binding crate name is parsed by just taking the last member in the path rather than removing a given prefix.
With the existing code, in the new test,
pyo3-mixed-workspace, themain_member_namegets parsed asrust/pyo3-mixed-workspace-pyand then does not get added into the resulting workspace Cargo.toml file in the source distribution. This causes a failure when trying to install the package from the resulting source distribution.The new test is based on this project structure: https://github.com/NREL/routee-compass