sdist-include option #296
Merged
sdist-include option #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request! Clippy complains about one thing, otherwise the code looks good. |
This allows including arbitrary data in source distributions that will not appear in cargo list, namely vendored packages.
|
@konstin ok fixed and a changelog entry added. |
|
Thank you! |
|
@konstin if you have time could you please tag a version for this? |
|
Sure, I've tagged 0.8.1. Should be available as soon as ci passes. |
|
@konstin thank you. I just tested the PEP 517 flow installing from PyPI, it works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows including arbitrary data in source distributions
that will not appear in cargo list, namely vendored packages.
It feels hacky but I think it's needed for a vendored package or the one Python crate, one Rust crate use case in #291.