Consider requires-python when searching for interpreters #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
reviewed
Apr 9, 2021
| @@ -176,9 +177,9 @@ impl BuildOptions { | |||
| // Only build a source distribution | |||
| Some(ref interpreter) if interpreter.is_empty() => vec![], | |||
| // User given list of interpreters | |||
| Some(interpreter) => find_interpreter(&bridge, &interpreter, &target)?, | |||
| Some(interpreter) => find_interpreter(&bridge, &interpreter, &target, None)?, | |||
There was a problem hiding this comment.
Should we also filter the user given list of interpreters if requires-python specified?
There was a problem hiding this comment.
No, in that case I'd trust the users list more than the PEP 440 heuristic
messense
approved these changes
Apr 9, 2021
konstin
force-pushed
the
requires_python_for_interpreter_search
branch
from
adf0717
to
4ac4f5b
Compare
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
May 8, 2021
https://build.opensuse.org/request/show/891567 by user mia + dimstar_suse - Update to 0.10.4 * Interpreter search now uses python 3.6 to 3.12 gh#PyO3/maturin#495 * Consider requires-python when searching for interpreters gh#PyO3/maturin#495 * Support Rust extension as a submodule in mixed Python/Rust project gh#PyO3/maturin#489
|
The error message isn't good when maturin can't find any interpreters with 🍹 Building a mixed python/rust project
🔗 Found pyo3 bindings
💥 maturin failed
Caused by: Couldn't find any python interpreters. Please specify at least one with -iIt's kinda confusing if user already has some other Python versions installed. It would be much nicer if it says |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195
Not sure if there's any better way to test this.