pyany: add PyAny::py() #1751
Merged
pyany: add PyAny::py() #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for 0.15. |
|
I've rebased this and begun merging other breaking changes for 0.15 now. Is anyone willing to review and approve / reject this? |
birkenfeld
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
PyAny::py()as a shortcut to get thePythonGIL token without importing thePyNativeTypetrait.I think this is a nice convenience as well as maybe being more discoverable for users (not many seem to know about the
PyNativeTypetrait).It'll probably make a few "unused import" warnings when users upgrade to a PyO3 containing this, so I wonder if it's nicer if this waits for 0.15?