Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: move fastcall boilerplate out of generated code #2085

merged 1 commit into from Jan 3, 2022


Copy link

Moves code for fastcall from proc macro output (converting arguments from raw pointers to slices etc) into pyo3::impl_::extract_argument.

This is a huge further reduction (~15%) of the LLVM line count of pyo3-pytests.

No noticeable change to benchmarks, so again this should be a nice compile speedup.

@davidhewitt davidhewitt force-pushed the opt-argument-extraction branch 6 times, most recently from 829edc4 to 8116002 Compare January 3, 2022 00:01
@davidhewitt davidhewitt merged commit be70e54 into PyO3:main Jan 3, 2022
@davidhewitt davidhewitt deleted the opt-argument-extraction branch January 3, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant