Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow #[classattr] methods to be fallible #2385

Merged
merged 1 commit into from
May 21, 2022

Conversation

davidhewitt
Copy link
Member

Noticed this morning while looking at #2382 that it's not possible to return PyResult from #[classattr] methods.

There's not much we can do with them but panic, but it is at least a nice consistency change to match other #[pymethods].

@davidhewitt
Copy link
Member Author

Anyone got any concerns before I merge this? I don't think it's essential at all, just seems like a sensible refinement.

@davidhewitt davidhewitt merged commit a21bd6f into PyO3:main May 21, 2022
@davidhewitt davidhewitt deleted the classattr-results branch May 21, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant