cleanup(examples) #161
Merged
cleanup(examples) #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntl to print, made a simpler chained logic command and fixed odd formatting)
Contributor
Author
|
Most of these are visual changes, but some of them are just good practices for python code |
Member
|
Thank you @vladdoster for cleaning this up! These examples definitely need some love. Would you mind running pylint and black over the These tools would lint and format the files approriately. |
giovtorres
added
Documentation
Enhancement
Community Contribution
Contributor
Author
|
@giovtorres, yes I can do that. Will push to upstream sometime today. |
Contributor
Author
|
@giovtorres I updated the tests! The remaining errors are mostly in sjobs relating to line-too-long and I wasn't really sure how to fix it since I am not at work and don't have access to slurm right now to see how it would look. Started out at ~3 and now pushing 10!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed redundant logic, removed broken example typo from
printltoprint, made a simpler chained logic command and fixed odd formattingI know they seem small, but we use pyslurm in production and its nice to show developers these and they use best conventions. Might as well fix them :)