Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use store_true for bool args #1822

Merged
merged 2 commits into from May 13, 2020

Conversation

williamFalcon
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team May 13, 2020 22:04
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #1822 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1822   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files          71      71           
  Lines        4450    4453    +3     
======================================
+ Hits         3909    3911    +2     
- Misses        541     542    +1     

@williamFalcon williamFalcon merged commit 648d516 into master May 13, 2020
@Borda Borda added the feature Is an improvement or enhancement label May 14, 2020
@Borda Borda added this to the 0.7.6 milestone May 14, 2020
@Borda Borda deleted the nateraw-feature/1168_argparse_bools branch May 28, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants