Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken trainer flags nb #4159

Merged
merged 6 commits into from Oct 15, 2020
Merged

Fix broken trainer flags nb #4159

merged 6 commits into from Oct 15, 2020

Conversation

nateraw
Copy link
Contributor

@nateraw nateraw commented Oct 15, 2020

What does this PR do?

Fixes issue where notebook json was corrupted somehow. uploaded via colab this time, hopefully it works.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@mergify mergify bot requested a review from a team October 15, 2020 00:36
@nateraw nateraw marked this pull request as draft October 15, 2020 00:59
@nateraw nateraw marked this pull request as ready for review October 15, 2020 01:22
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #4159 into master will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4159    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         103     103            
  Lines        7798    8360   +562     
=======================================
+ Hits         7232    7364   +132     
- Misses        566     996   +430     

@mergify mergify bot requested a review from a team October 15, 2020 07:19
Borda and others added 2 commits October 15, 2020 09:38
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
@mergify mergify bot requested a review from a team October 15, 2020 20:35
@mergify mergify bot requested a review from a team October 15, 2020 20:45
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
@Borda Borda merged commit 130de22 into Lightning-AI:master Oct 15, 2020
@Borda Borda added this to the 1.0.x milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants