Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import and typo in AMP #4871

Merged
merged 6 commits into from Nov 26, 2020
Merged

fix import and typo in AMP #4871

merged 6 commits into from Nov 26, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Nov 26, 2020

What does this PR do?

Partial #4859

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added bug Something isn't working refactor priority: 1 Medium priority task labels Nov 26, 2020
@Borda Borda added this to the 1.1 milestone Nov 26, 2020
@Borda Borda requested a review from awaelchli November 26, 2020 16:56
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM !

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one clarification. Else LGTM.

@Borda Borda added the ready PRs ready to be merged label Nov 26, 2020
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #4871 (8730301) into master (742ddd8) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4871   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         118     118           
  Lines        9036    9015   -21     
======================================
- Hits         8408    8393   -15     
+ Misses        628     622    -6     

@Borda Borda added the 3rd party Related to a 3rd-party label Nov 26, 2020
@Borda Borda merged commit 11e73ce into master Nov 26, 2020
@Borda Borda deleted the refactor/imports-amp branch November 26, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party bug Something isn't working priority: 1 Medium priority task ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants