Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move save_hyperparameters to its own function #7119

Merged
merged 7 commits into from Apr 20, 2021
Merged

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Apr 20, 2021

What does this PR do?

Motivation

Would like to add save_hyperparemeters to Flash Preprocess / Postprocess, so we don't pickle the object.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@tchaton tchaton added this to the v1.3 milestone Apr 20, 2021
@tchaton tchaton self-assigned this Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #7119 (26ae30f) into master (0302b8b) will decrease coverage by 0%.
The diff coverage is 97%.

@@           Coverage Diff           @@
##           master   #7119    +/-   ##
=======================================
- Coverage      92%     92%    -0%     
=======================================
  Files         197     197            
  Lines       12645   12769   +124     
=======================================
+ Hits        11661   11733    +72     
- Misses        984    1036    +52     

Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What motivates this change? Just reorganizing?

pytorch_lightning/core/lightning.py Show resolved Hide resolved
pytorch_lightning/utilities/parsing.py Outdated Show resolved Hide resolved
tchaton and others added 2 commits April 20, 2021 12:56
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
@tchaton
Copy link
Contributor Author

tchaton commented Apr 20, 2021

What motivates this change? Just reorganizing?

Hey @carmocca, I would like to add save_hyperparemeters to Flash Preprocess / Postprocess, so we don't pickle the object. I needed the function to be extracted and merged in the next rc.

Best,
T.C

pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
@tchaton tchaton enabled auto-merge (squash) April 20, 2021 13:35
@lexierule lexierule disabled auto-merge April 20, 2021 15:04
@lexierule lexierule merged commit ca21da4 into master Apr 20, 2021
@lexierule lexierule deleted the save_hyperparameters branch April 20, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants