Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve UserWarning message #7685

Merged
merged 5 commits into from May 25, 2021

Conversation

Lucklyric
Copy link
Contributor

@Lucklyric Lucklyric commented May 24, 2021

improve UserWarning message when both overfit and training dataloader shuffling are enabled

What does this PR do?

Fixes #7656

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

when both overfit and training dtaloader shuffling are enabled

fixes issue: Lightning-AI#7656
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #7685 (5a7f347) into master (ad168fc) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7685    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         199     199            
  Lines       12957   12957            
=======================================
- Hits        11988   11368   -620     
- Misses        969    1589   +620     

Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
pytorch_lightning/trainer/data_loading.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the feature Is an improvement or enhancement label May 24, 2021
@awaelchli awaelchli added this to the v1.3.x milestone May 24, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@carmocca carmocca modified the milestones: v1.3.x, v1.4 May 24, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) May 25, 2021 17:10
@rohitgr7 rohitgr7 merged commit 7e2f7e9 into Lightning-AI:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overfit when Shuffle is True
5 participants