-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: ensure tests are included in wheels #292
Conversation
0f6a673
to
c10aa03
Compare
A test unrelated to this PR is failing:
|
I can't reproduce the failure locally, but it's consistent on TravisCI it looks like. I'm tempted to just delete that test. We're removing that deprecated code anyway before the next release. |
the same error is also present in python 2.7 on Appveyor, but I do not see it locally when using 2.7. I would be find with removing that test. |
Nice to see tests for wheel and sdist builds were added on Travis! I see you have included the files via |
Failing test removed, seems happy now. |
One is that |
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 21 21
Lines 3086 3086
Branches 532 532
=======================================
Hits 2662 2662
- Misses 371 372 +1
+ Partials 53 52 -1
Continue to review full report at Codecov.
|
Thanks @rgommers! |
Also test install via sdist and wheel on TravisCI. Closes gh-280.