Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: ensure tests are included in wheels #292

Merged
merged 3 commits into from
Mar 8, 2017

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Mar 7, 2017

Also test install via sdist and wheel on TravisCI. Closes gh-280.

@rgommers rgommers added this to the v1.0 milestone Mar 7, 2017
@rgommers rgommers force-pushed the package-tests branch 2 times, most recently from 0f6a673 to c10aa03 Compare March 7, 2017 11:30
@rgommers
Copy link
Member Author

rgommers commented Mar 7, 2017

A test unrelated to this PR is failing:

FAIL: test_deprecations.test_MODES_attributes_usage_deprecation
....
AssertionError: No warning raised when calling dwt

@rgommers
Copy link
Member Author

rgommers commented Mar 7, 2017

I can't reproduce the failure locally, but it's consistent on TravisCI it looks like. I'm tempted to just delete that test. We're removing that deprecated code anyway before the next release.

@grlee77
Copy link
Contributor

grlee77 commented Mar 7, 2017

the same error is also present in python 2.7 on Appveyor, but I do not see it locally when using 2.7.

I would be find with removing that test.

@grlee77
Copy link
Contributor

grlee77 commented Mar 7, 2017

Nice to see tests for wheel and sdist builds were added on Travis!

I see you have included the files via package_data rather than adding an __init__.py in the test folders. I don't see a problem with doing it that way, but out of curiosity, do you recall the drawbacks of the __init__.py approach?

@rgommers
Copy link
Member Author

rgommers commented Mar 7, 2017

Failing test removed, seems happy now.

@rgommers
Copy link
Member Author

rgommers commented Mar 7, 2017

do you recall the drawbacks of the __init__.py approach?

One is that tests will start to show up when tab-completing. There was something more subtle as well, but can't remember.

@codecov-io
Copy link

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files          21       21           
  Lines        3086     3086           
  Branches      532      532           
=======================================
  Hits         2662     2662           
- Misses        371      372    +1     
+ Partials       53       52    -1
Impacted Files Coverage Δ
pywt/_wavelet_packets.py 78.12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ee638...6fe10af. Read the comment docs.

@grlee77 grlee77 merged commit 3d0ab16 into PyWavelets:master Mar 8, 2017
@grlee77
Copy link
Contributor

grlee77 commented Mar 8, 2017

Thanks @rgommers!

@grlee77 grlee77 mentioned this pull request Mar 8, 2017
@rgommers rgommers deleted the package-tests branch March 8, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants