TST: Explicity align data records in test_byte_offset() #314
Conversation
|
The unaligned array accesses cause crash on Ubuntu armhf and Debian sparc64 build servers: |
|
Thanks @rbalint! This looks good to me. I will merge later this weekend if there are no objections. |
pywt/tests/test_multidim.py
Outdated
| @@ -88,8 +88,9 @@ def test_byte_offset(): | |||
|
|
|||
| for mode in pywt.Modes.modes: | |||
| expected = pywt.dwtn(data, wavelet) | |||
| padded = np.ones((3, 6), dtype=np.dtype([('data', data.dtype), | |||
| ('pad', 'byte')])) | |||
| padded = np.ones((3, 6), dtype=np.dtype({'ddata': (data.dtype, 0), | |||
There was a problem hiding this comment.
Can you change this field name from 'ddata' back to 'data'? It is causing one test failure as is
Also use dict for dtype definition because list format ignores alignment. See numpy/numpy#663
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
+ Coverage 86.22% 86.25% +0.03%
==========================================
Files 21 21
Lines 3092 3092
Branches 535 535
==========================================
+ Hits 2666 2667 +1
Misses 373 373
+ Partials 53 52 -1
Continue to review full report at Codecov.
|
Also use dict for dtype definition because list format
ignores alignment. See numpy/numpy#663