provide a more helpful error message for wrong wavelet type #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovided This PR will cause all discrete transforms to provide a helpful error message if they are called with a ContinousWavelet object or a name corresponding to a ContinuousWavelet.
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 86.22% 86.29% +0.07%
==========================================
Files 21 21
Lines 3099 3094 -5
Branches 562 556 -6
==========================================
- Hits 2672 2670 -2
+ Misses 374 373 -1
+ Partials 53 51 -2
Continue to review full report at Codecov.
|
|
LGTM, thanks @grlee77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current master, providing the name of a continuous wavelet to a discrete transform such as
wavedecnresults in the non-obviousAttributeErrorshown in #333This PR provides a helpful error message when discrete transforms are called with either a
ContinuousWaveletobject or a name corresponding to aContinuousWavelet. In all cases, the error message is provided either directly via_as_wavelet(or indirectly via_wavelets_per_axis).New tests verify that a
ValueErrorrather thanAttributeErroris raised for each of the discrete transforms.closes #333