Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove pyproject.toml #366

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

saketkc
Copy link
Contributor

@saketkc saketkc commented Apr 21, 2018

Based on @grlee77's comment.
Also, see scipy/scipy#8735

@codecov-io
Copy link

Codecov Report

Merging #366 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   83.78%   83.55%   -0.24%     
==========================================
  Files          21       21              
  Lines        3251     3332      +81     
  Branches      537      567      +30     
==========================================
+ Hits         2724     2784      +60     
- Misses        466      484      +18     
- Partials       61       64       +3
Impacted Files Coverage Δ
pywt/_extensions/c/wt.template.c 87.38% <0%> (-7.78%) ⬇️
pywt/_extensions/c/common.c 94.44% <0%> (-5.56%) ⬇️
pywt/_extensions/c/wavelets.c 85.74% <0%> (-1.39%) ⬇️
pywt/_extensions/c/convolution.template.c 97.48% <0%> (-1.22%) ⬇️
pywt/_wavelet_packets.py 78.12% <0%> (ø) ⬆️
pywt/_extensions/c/cwt.template.c 97.89% <0%> (+0.04%) ⬆️
pywt/_utils.py 80.76% <0%> (+15.38%) ⬆️
pywt/__init__.py 96.15% <0%> (+19.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7be1f...1ccd66a. Read the comment docs.

@grlee77
Copy link
Contributor

grlee77 commented Apr 23, 2018

Thanks. This seems to have fixed the issue, but I will leave open for a bit to see if there is any other feedback.

@rgommers
Copy link
Member

Makes sense. These issues will likely be fixed in pip before long; we can then add it back.

@grlee77 grlee77 merged commit 3c00702 into PyWavelets:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants