Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not force float64 dtype on assignment to Node, Node2D #392

Merged
merged 5 commits into from
Jul 26, 2018

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jul 23, 2018

This PR removes the explicit casts to float64 from the wavelet packets code, enabling packets with the other dtypes supported by the DWT (float32, complex64 and complex128).

@grlee77 grlee77 added this to the v1.0 milestone Jul 23, 2018
@grlee77 grlee77 changed the title do not force float64 dtype in WaveletPackets WIP: do not force float64 dtype in WaveletPackets Jul 23, 2018
@grlee77
Copy link
Contributor Author

grlee77 commented Jul 23, 2018

Actually, on closer look, the dtype tests used here already pass on current master. It is only on assigning data to nodes that things were being forced to np.float64. Let me update the release note text and tests to reflect that before reviewing this one.

@grlee77 grlee77 added bug and removed enhancement labels Jul 23, 2018
@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #392 into master will decrease coverage by 0.05%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage    84.5%   84.45%   -0.06%     
==========================================
  Files          22       22              
  Lines        3595     3596       +1     
  Branches      624      625       +1     
==========================================
- Hits         3038     3037       -1     
- Misses        489      490       +1     
- Partials       68       69       +1
Impacted Files Coverage Δ
pywt/_wavelet_packets.py 77.57% <80%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 702d519...58cd9ce. Read the comment docs.

@grlee77
Copy link
Contributor Author

grlee77 commented Jul 23, 2018

Okay, this is good to review now. I have changed the label to bug since transforms in the other dtypes did work before. It is just assigning data to a node that caused the cast to float64. Only the test added in the last commit here fails on current master. The rest of the new tests pass on current master as well, but it doesn't hurt to test these other dtypes explicitly.

@grlee77 grlee77 changed the title WIP: do not force float64 dtype in WaveletPackets do not force float64 dtype in WaveletPackets Jul 23, 2018
@grlee77 grlee77 changed the title do not force float64 dtype in WaveletPackets do not force float64 dtype on assignment to Node, Node2D Jul 23, 2018
@rgommers rgommers merged commit 8b1e3f1 into PyWavelets:master Jul 26, 2018
@rgommers
Copy link
Member

LGTM, merged. Thanks @grlee77

@grlee77 grlee77 deleted the wpacket_dtypes branch August 28, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants