-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not force float64 dtype on assignment to Node, Node2D #392
Conversation
Actually, on closer look, the dtype tests used here already pass on current master. It is only on assigning data to nodes that things were being forced to np.float64. Let me update the release note text and tests to reflect that before reviewing this one. |
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 84.5% 84.45% -0.06%
==========================================
Files 22 22
Lines 3595 3596 +1
Branches 624 625 +1
==========================================
- Hits 3038 3037 -1
- Misses 489 490 +1
- Partials 68 69 +1
Continue to review full report at Codecov.
|
Okay, this is good to review now. I have changed the label to |
LGTM, merged. Thanks @grlee77 |
This PR removes the explicit casts to float64 from the wavelet packets code, enabling packets with the other dtypes supported by the DWT (float32, complex64 and complex128).