This repository has been archived by the owner. It is now read-only.

Strip `pyconuk.org` from URLs when checking output HTML #20

Merged
merged 1 commit into from Apr 5, 2015

Conversation

Projects
None yet
2 participants
@doismellburning
Copy link
Member

doismellburning commented Apr 4, 2015

Canonical links should include the domain part, but html-proofer just
treats them as normal external links (see
gjtorikian/html-proofer#170) so will fail on
PRs adding new pages.

Ideally html-proofer would just strip the domain part from canonical
links, but until then, this just strips the pyconuk.org domain part
from all hrefs - not quite ideal, but avoids me writing Ruby.

Strip `pyconuk.org` from URLs when checking output HTML
Canonical links should include the domain part, but `html-proofer` just
treats them as normal external links (see
gjtorikian/html-proofer#170) so will fail on
PRs adding new pages.

Ideally `html-proofer` would just strip the domain part from canonical
links, but until then, this just strips the `pyconuk.org` domain part
from _all_ `href`s - not quite ideal, but avoids me writing Ruby.

inglesp added a commit that referenced this pull request Apr 5, 2015

Merge pull request #20 from PyconUK/feature/canonical-url-check-hackery
Strip `pyconuk.org` from URLs when checking output HTML

@inglesp inglesp merged commit a20e16e into master Apr 5, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@inglesp inglesp deleted the feature/canonical-url-check-hackery branch Apr 5, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.