fixing issue with not working audo_recordings example#1466
Closed
TheGiga wants to merge 1 commit into
Closed
Conversation
I fixed an error that was caused probably by using enum, but im not sure. My personal opinion, is that pevious example was cleaner and simply better. Had to use dict once again, because i was too lazy to fix Enum thing, if someone wants to try fixing it using Enum - you're welcome. I prefer using Enum aswell, because it looks cooler, but it just didn't work well here.
EmmmaTech
approved these changes
Jul 4, 2022
EmmmaTech
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but you might want to change the name of this PR to sound more confident that this is the fix.
Member
|
This doesn't fix the issue with the enum, instead just removes it. |
Contributor
Author
that's why im calling it possible fix, but yes, i could named it better. |
Member
|
I think we should fix the issue instead of removing this all |
Member
|
The issue doesn't even lie in the example, rather in the library. I'll try to fix that. |
Member
|
Closing as invalid. |
Member
|
ef301fc should fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed an error that was caused probably by using enum, but im not sure.
My personal opinion, is that pevious example was cleaner and simply better.
Had to use dict once again, because i was too lazy to fix Enum thing, if someone wants to try fixing it using Enum - you're welcome.
I prefer using Enum aswell, because it looks cooler, but it just didn't work well here.
There is some error messages that user on pycord's discord server was getting:
I was able to recreate the issue by simply trying to use code from example:

With updated code i got it to work:
Information
Checklist
type: ignorecomments were used, a comment is also left explaining why.