Skip to content

fixing issue with not working audo_recordings example#1466

Closed
TheGiga wants to merge 1 commit into
Pycord-Development:masterfrom
TheGiga:patch-2
Closed

fixing issue with not working audo_recordings example#1466
TheGiga wants to merge 1 commit into
Pycord-Development:masterfrom
TheGiga:patch-2

Conversation

@TheGiga

@TheGiga TheGiga commented Jul 3, 2022

Copy link
Copy Markdown
Contributor

Summary

I fixed an error that was caused probably by using enum, but im not sure.
My personal opinion, is that pevious example was cleaner and simply better.
Had to use dict once again, because i was too lazy to fix Enum thing, if someone wants to try fixing it using Enum - you're welcome.

I prefer using Enum aswell, because it looks cooler, but it just didn't work well here.

There is some error messages that user on pycord's discord server was getting:

image

I was able to recreate the issue by simply trying to use code from example:
image

With updated code i got it to work:

p9MvbK0hvd

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

I fixed an error that was caused probably by using enum, but im not sure.
My personal opinion, is that pevious example was cleaner and simply better.
Had to use dict once again, because i was too lazy to fix Enum thing, if someone wants to try fixing it using Enum - you're welcome.

I prefer using Enum aswell, because it looks cooler, but it just didn't work well here.

@EmmmaTech EmmmaTech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you might want to change the name of this PR to sound more confident that this is the fix.

@Dorukyum

Dorukyum commented Jul 4, 2022

Copy link
Copy Markdown
Member

This doesn't fix the issue with the enum, instead just removes it.

@TheGiga

TheGiga commented Jul 4, 2022

Copy link
Copy Markdown
Contributor Author

This doesn't fix the issue with the enum, instead just removes it.

that's why im calling it possible fix, but yes, i could named it better.
At least, this works.

@TheGiga TheGiga changed the title POSSIBLE fix to an issue with enum. fixing issue with not working audo_recordings example Jul 4, 2022
@Lulalaby

Lulalaby commented Jul 4, 2022

Copy link
Copy Markdown
Member

I think we should fix the issue instead of removing this all

@Dorukyum

Dorukyum commented Jul 4, 2022

Copy link
Copy Markdown
Member

The issue doesn't even lie in the example, rather in the library. I'll try to fix that.

@Lulalaby

Lulalaby commented Jul 4, 2022

Copy link
Copy Markdown
Member

Closing as invalid.
Fix needs to be done in library.
@Dorukyum will look into this.

@Lulalaby Lulalaby closed this Jul 4, 2022
@Lulalaby Lulalaby added the invalid This doesn't seem right label Jul 4, 2022
@TheGiga TheGiga deleted the patch-2 branch July 4, 2022 15:02
@Dorukyum

Dorukyum commented Jul 4, 2022

Copy link
Copy Markdown
Member

ef301fc should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants