Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Revert ID name change #130

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
2 participants
@Ebag333
Copy link

commented Jun 26, 2017

Reverts a rename to a parameter, as wx requires it to be named ID specifically.

@codacy-bot

This comment has been minimized.

Copy link

commented Jun 26, 2017

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

@@ -741,14 +741,14 @@ def _Render(self):


class PFTabsContainer(wx.Panel):
def __init__(self, parent, pos=(0, 0), size=(100, 22), init_id=wx.ID_ANY, canAdd=True):
def __init__(self, parent, pos=(0, 0), size=(100, 22), id=wx.ID_ANY, canAdd=True):

This comment has been minimized.

Copy link
@codacy-bot
@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2017

Codecov Report

Merging #130 into development will decrease coverage by <.01%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           development     #130      +/-   ##
===============================================
- Coverage        14.65%   14.65%   -0.01%     
===============================================
  Files             2177     2177              
  Lines            35963    37160    +1197     
===============================================
+ Hits              5272     5444     +172     
- Misses           30691    31716    +1025

@Ebag333 Ebag333 merged commit a5a91b9 into development Jun 26, 2017

3 of 8 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
code-quality/landscape New errors were found. Score decreased by None
Details
codecov/patch 0% of diff hit (target 14.65%)
Details
codecov/project 14.65% (-0.01%) compared to abfdd49
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Ebag333 Ebag333 deleted the bugfix_ID_name branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.