Fix Hive reauth loop by persisting device metadata; add debug 2FA toggle#193
Merged
KJonline merged 1 commit intoFeb 27, 2026
Conversation
Contributor
|
@tamunro93 i've just released the official version on 1.0.8 Do you want to update your PR to use that version please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a reauth loop seen when Hive refresh token fallback occurs after an initially successful login.
In affected cases, login returns AuthenticationResult with NewDeviceMetadata, but device_data is not persisted in the config entry. Later fallback device auth then fails and repeatedly reauths.
This PR:
Changes
Repro / Symptoms
Observed recurring errors before fix:
After this patch, device_data is persisted for successful login flows returning NewDeviceMetadata, and the reauth loop is resolved in my tested environment.
Notes:
I understand 1.0.8.dev10 is a dev dependency and may change before official 1.0.8. Happy to adjust dependency/version strategy based on maintainer preference. Also, thanks for the heads-up on the other 1.0.8 dev PR; happy to align/rebase this against it or reduce this PR to only the debug-toggle bits if preferred.