Skip to content

Add Set schematype (backported from deform.Set) #71

Merged
merged 3 commits into from Nov 21, 2012

2 participants

@domenkozar
Pylons Project member

No description provided.

@mcdonc
Pylons Project member

This should probably be checked using "colander.compat.is_nonstr_iter"

Pylons Project member

Done.

@mcdonc
Pylons Project member

Although this may be the way it was coded in deform, and other schema types return null when the cstruct evals boolean false, I think this thing should probably return the empty set rather than null (as an empty set is a valid set, and isn't necessarily, null, it's just empty).

Pylons Project member

The plan was to keep consistency with all the other types, but I agree - empty set is a valid use case.

Pylons Project member

Done.

@mcdonc mcdonc merged commit f965008 into master Nov 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.