Trying to create an api for allowing a list of validators, deferred or n... #95

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jayd3e
Member
jayd3e commented Mar 19, 2013

...ot.

@tseaver tseaver commented on the diff Nov 26, 2014
colander/tests/test_colander.py
@@ -3363,6 +3385,11 @@ def __call__(self, node, value):
self.children and e.children.extend(self.children)
raise e
+from colander import deferred
tseaver
tseaver Nov 26, 2014 Owner

Please don't import the package at testcase module scope. Move this code inside a helper method, e.g.

def _makeDummyDeferredValidateor(self):
    from colander import deferred
    def _validator(node, kw):
        return DummyValidator(kw..get('message', 'Deferred'))
    return deferred(_validator)
Owner
tseaver commented Nov 26, 2014

Thank you for the patch. Can you please:

  • Add an entry to CHANGES.rst.
  • Add your name to CONTRIBUTORS.txt.
Owner
tseaver commented Feb 4, 2015

@jayd3e, could you merge with master and re-push as well?

Member
jayd3e commented Feb 4, 2015

Yeah definitely. I'll fit it in sometime this morning.

@mmerickel mmerickel closed this Aug 15, 2016
Owner

Closed as this has obviously stagnated. Reopen if you wish to bring this PR up to date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment