Missing drop #98

Merged
merged 2 commits into from Mar 20, 2013

Conversation

Projects
None yet
3 participants
@jayd3e
Contributor

jayd3e commented Mar 19, 2013

I basically just added some docs to issue #84. Seems ready to go to me.

@mcdonc mcdonc merged commit a564f43 into Pylons:master Mar 20, 2013

@abrookins

This comment has been minimized.

Show comment Hide comment
@abrookins

abrookins Mar 25, 2013

Contributor

Thanks for adding docs, Joe.

I always appreciate having a "How to submit patches" checklist in the library docs, to help make sure I touch all the bases when submitting. Does Colander have one of those?

Something like:

  • Clone the repo
  • Create a branch for your patch
  • Write code
  • Add tests
  • Add docs if the patch introduces a new feature
  • Submit pull request

I know that workflow is pretty much standard, but it's always nice to be explicit about it anyway. I'd be happy to add docs for this if it doesn't already exist.

Contributor

abrookins commented Mar 25, 2013

Thanks for adding docs, Joe.

I always appreciate having a "How to submit patches" checklist in the library docs, to help make sure I touch all the bases when submitting. Does Colander have one of those?

Something like:

  • Clone the repo
  • Create a branch for your patch
  • Write code
  • Add tests
  • Add docs if the patch introduces a new feature
  • Submit pull request

I know that workflow is pretty much standard, but it's always nice to be explicit about it anyway. I'd be happy to add docs for this if it doesn't already exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment