Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing internationalization in Label and Description #162

Open
szczad opened this issue May 15, 2013 · 2 comments
Open

Missing internationalization in Label and Description #162

szczad opened this issue May 15, 2013 · 2 comments

Comments

@szczad
Copy link

szczad commented May 15, 2013

Hi,

There is problem with missing invalidation of "subject" and "confirm_subject" variables in deform.widget.CheckedPasswordWidget template. CheckedInputWidget works great but not password widget. Instead of
line no. 8:<label for="${oid}" i18n:translate="">Password</label>
and
line no. 14:<label for="${oid}-confirm" i18n:translate="">Confirm Password</label>

it should be probably
line no. 8:<label for="${oid}" i18n:translate="">${subject}</label>
and
line no. 14:<label for="${oid}-confirm" i18n:translate="">${confirm_subject}</label>

@stevepiercy
Copy link
Member

stevepiercy commented Aug 24, 2020

With Deform 2, templates have changed. Nonetheless, translations should be supported in <label> and in the help messages, as derived from the title and description of the SchemaNode. Error messages already support translations.

Check all templates that contain either description} or title}.

@stevepiercy stevepiercy added this to the 3.0.0 milestone Aug 24, 2020
@stevepiercy stevepiercy changed the title Missing internalization in CheckedPasswordWidget Missing internalization in Label and Description Aug 24, 2020
@stevepiercy stevepiercy changed the title Missing internalization in Label and Description Missing internationalization in Label and Description Aug 24, 2020
@szczad szczad closed this as completed Oct 31, 2022
@stevepiercy
Copy link
Member

This was not completed. Reopening.

See example by appending a locale to the URL, for example: ?_LOCALE_=de.

https://deformdemo.pylonsproject.org/checkedpassword/?_LOCALE_=de

@stevepiercy stevepiercy reopened this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants