Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Structural widgets should use css_class of items on container #98

Closed
rbu opened this Issue Jun 22, 2012 · 6 comments

Comments

Projects
None yet
4 participants
Contributor

rbu commented Jun 22, 2012

When styling a structured form (using a mapping), "page furniture" is introduced around a field widget by the mapping. It is rather inconvenient and error-prone to apply any styling to the containing li elements based on the css_class of a contained elment (e.g., an input tag).

The structural widgets should apply the inner css class to the item container they render directly.

Contributor

rbu commented Aug 24, 2012

I'm happy to provide a patch, but I would appreciate general consent with the idea first so I don't provide waste.

Owner

mcdonc commented Aug 24, 2012

I'm afraid a patch will be required to understand what you're getting at( even if it is later rejected, for better or worse, sorry).

Contributor

rbu commented Aug 29, 2012

see referenced patch for a proposed implementation

Member

kiorky commented Sep 21, 2012

tied to #97, go on with a pullrequest !!!

rbu added a commit to rbu/deform that referenced this issue Oct 24, 2012

Contributor

rbu commented Nov 22, 2012

ping

Member

cguardia commented Mar 20, 2013

This is being addressed on issue #131. Closing this to reduce noise.

@cguardia cguardia closed this Mar 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment