Text can appear to the right of a checkbox. #115

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

It is traditional. Checkboxes have text to the right of them. To the point
it seems incomplete, like something is missing, if the label isn't there.
It is even hard to click...

I fear there may be some ideology to the lack of this text in Deform.
It certainly would already be there if you thought it important... Of
course I understand that Deform already offers a label that appears on the
top and some help text that may appear below each control. I just think
it would be nice to offer this additional text possibility for checkboxes,
out of the box.

In the implementation, I have chosen a "text" attribute on the schema itself.
The name of the attribute is very negotiable, I just don't have any
better ideas. When the attribute is lacking, the label doesn't appear.

Really hoping you don't have serious objections to this...

@nandoflorestan nandoflorestan Text can appear to the right of a checkbox.
It is traditional. Checkboxes have text to the right of them. To the point
it seems incomplete, like something is missing, if the label isn't there.
It is even hard to click...

I fear there may be some ideology to the lack of this text in Deform.
It certainly would already be there if you thought it important... Of
course I understand that Deform already offers a label that appears on the
top and some help text that may appear below each control. I just think
it would be nice to offer this additional text possibility for checkboxes,
out of the box.

In the implementation, I have chosen a "text" attribute on the schema itself.
The name of the attribute is very negotiable, I just don't have any
better ideas. When the attribute is lacking, the label doesn't appear.

Really hoping you don't have serious objections to this...
3a6e9eb
Member

kiorky commented Sep 21, 2012

maybe better to help?

Sorry, I don't know what you are saying there. Do you mean that a "help" attribute would be a better choice than "text"? Why?

Member

kiorky commented Oct 20, 2012

Yes an help attribute

Owner

chrisrossi commented Mar 20, 2013

This is probably ok, but it needs to be rebased.

Member

cguardia commented Mar 20, 2013

Fixed with 386abd8

cguardia closed this Mar 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment