Avoid duplicate label for 'checked password widget' and add 'required' span on confirmation field. #38

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
@malthe
Member

malthe commented Aug 13, 2011

Don't include 'duplicate' label for initial password field; most likely, the field itself will have a title 'Enter password' and there's no reason to repeat that. Besides, it makes it very difficult to style the form. Also, add the 'required' span element on the confirmation field if applicable.

malthe added some commits Aug 13, 2011

Don't include 'duplicate' label for initial password field; most like…
…ly, the field itself will have a title 'Enter password' and there's no reason to repeat that. Besides, it makes it very difficult to style the form. Also, add the 'required' span element on the confirmation field if applicable.
Add an additional css class to each mapping item corresponding to the…
… widget class name, but mangled such that the camel case class name appears in lowercase with dashes separating words.
@kiorky

This comment has been minimized.

Show comment
Hide comment
@kiorky

kiorky Dec 7, 2011

Please add the class just in addtionnal mode like:

class="field ${field.error and ' ' + field.widget.error_class} ${field.widget.css_name}${field.error and ' ' + field.widget.error_class}"

kiorky commented on a83dd03 Dec 7, 2011

Please add the class just in addtionnal mode like:

class="field ${field.error and ' ' + field.widget.error_class} ${field.widget.css_name}${field.error and ' ' + field.widget.error_class}"
@kiorky

This comment has been minimized.

Show comment
Hide comment
@kiorky

kiorky Dec 7, 2011

Member

Please commit in a separate branch the css stuff.
Other is irrelevant i think for deform.

Member

kiorky commented Dec 7, 2011

Please commit in a separate branch the css stuff.
Other is irrelevant i think for deform.

@sontek

This comment has been minimized.

Show comment
Hide comment
@sontek

sontek May 2, 2012

Member

The pull request was created 9 months ago and he hasn't responded to the requests. Is this still relevant?

Member

sontek commented May 2, 2012

The pull request was created 9 months ago and he hasn't responded to the requests. Is this still relevant?

@kiorky

This comment has been minimized.

Show comment
Hide comment
@kiorky

kiorky May 2, 2012

Member

That was my question at first and wanted malthe to answer...
We may close it next month (for the record)...

Member

kiorky commented May 2, 2012

That was my question at first and wanted malthe to answer...
We may close it next month (for the record)...

@malthe

This comment has been minimized.

Show comment
Hide comment
@malthe

malthe May 2, 2012

Member

You can just cherry-pick whatever commits you like from this.

I don't think I need to set up multiple branches in order to contribute these patches.

Member

malthe commented May 2, 2012

You can just cherry-pick whatever commits you like from this.

I don't think I need to set up multiple branches in order to contribute these patches.

@kiorky kiorky closed this Jul 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment