- More informative error message when a config.include cannot fin…

…d an

  ``includeme``.  See #392.

Closes #392.

CHANGES.txt

@@ -1,6 +1,12 @@
 Next release
 ============
 
+Features
+--------
+
+- More informative error message when a ``config.include`` cannot find an
+  ``includeme``.  See https://github.com/Pylons/pyramid/pull/392.
+
 Bug Fixes
 ---------
 

pyramid/config/__init__.py

@@ -704,7 +704,13 @@ def main(global_config, **settings):
         c = self.maybe_dotted(callable)
         module = inspect.getmodule(c)
         if module is c:
-            c = getattr(module, 'includeme')
+            try:
+                c = getattr(module, 'includeme')
+            except AttributeError:
+                raise ConfigurationError(
+                    "module %r has no attribute 'includeme'" % (module.__name__)
+                    )
+
         spec = module.__name__ + ':' + c.__name__
         sourcefile = inspect.getsourcefile(c)
 

pyramid/tests/test_config/test_init.py

@@ -712,6 +712,11 @@ def test_include_with_module_defaults_to_includeme(self):
         self.assertEqual(action['callable'], None)
         self.assertEqual(action['args'], test_config)
 
+    def test_include_with_module_defaults_to_includeme_missing(self):
+        from pyramid.exceptions import ConfigurationError
+        config = self._makeOne()
+        self.assertRaises(ConfigurationError, config.include, 'pyramid.tests')
+
     def test_include_with_route_prefix(self):
         root_config = self._makeOne(autocommit=True)
         def dummy_subapp(config):