/pyramid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyramid tests set invalid status on Response() objects #1864

Closed
bertjwregeer opened this Issue Jul 30, 2015 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bertjwregeer @mmerickel
@bertjwregeer
Member

bertjwregeer commented Jul 30, 2015

Due to changes in WebOb 1.5.0 (specifically: https://github.com/Pylons/webob/blob/master/docs/news.txt#L14) when Pyramid uses _HTTPMove() in tests, it doesn't set the appropriate code and title this passing None None as the Response()'s status.

In WebOb 1.5.0 this has become more strict, so that rather than blowing up at time of use (for example when the Response object is actually used to start_response, it now blows up when the status is being set. This makes for a better API whereby you are not left guessing why WebOb blew up at a later time, and instead it is done at the call site.

This breaks Pyramid's tests as seen on Travis CI: https://travis-ci.org/Pylons/pyramid/jobs/73282779

@bertjwregeer bertjwregeer referenced this issue Aug 3, 2015

Merged

Fix Pyramid against WebOb >=1.5.0 #1865

@mmerickel

This comment has been minimized.

Show comment
Hide comment
@mmerickel

mmerickel Aug 31, 2015

Member

Fixed via #1865.
Member

mmerickel commented Aug 31, 2015

Fixed via #1865.

@mmerickel mmerickel closed this Aug 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment