Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HACKING.txt and Pyramid's setup.py to use pip #2474

Closed
stevepiercy opened this issue Apr 11, 2016 · 7 comments
Closed

Update HACKING.txt and Pyramid's setup.py to use pip #2474

stevepiercy opened this issue Apr 11, 2016 · 7 comments
Milestone

Comments

@stevepiercy
Copy link
Member

In relation to #2104, Pyramid's HACKING.txt and setup.py should be updated to use pip for consistency. However this is outside the scope of #2104 because it's not "docs" and it needs special attention from developers who work on Pyramid's core and understand implications of such a change.

The three scaffold's setup.pys have been updated for the Pyramid 1.7 release already on docs/easy-install-to-pip.2104, and may serve as examples of the proposed changes.

@digitalresistor digitalresistor added this to the 1.7 milestone Apr 12, 2016
@stevepiercy
Copy link
Member Author

Changes to setup.py

Current

testing_extras = tests_require + [
    'nose',
    'coverage',
    'virtualenv', # for scaffolding tests
    ]
...
      extras_require={
          'testing': testing_extras,
          'docs': docs_extras,
          },
      tests_require=tests_require,
      test_suite="pyramid.tests",

Proposed

tests_require = [
    'WebTest >= 1.3.1',  # py3 compat
    'pytest',  # includes virtualenv
    'pytest-cov',
    ]
...
      extras_require={
          'testing': tests_require,
          'docs': docs_extras,
          },

Would this break anything I might have overlooked?

@mmerickel
Copy link
Member

That particular change is fine to make. Our tox file is already using pip as well. We should update our HACKING docs to recommend the similar workflow but I can do that myself later tonight.

stevepiercy added a commit to stevepiercy/pyramid that referenced this issue Apr 13, 2016
- remove unnecessary tests stuff
- see Pylons#2474
@digitalresistor
Copy link
Member

If we remove nose we need to update our tox to start using py.test as well instead of nosetests.

@digitalresistor
Copy link
Member

This is the tox file I use for pyramid_authsanity: https://github.com/usingnamespace/pyramid_authsanity/blob/master/tox.ini

@mmerickel
Copy link
Member

Removing nose in pyramid core should not part of these changes. I renamed the PR to reflect that. I didn't realize that was something @stevepiercy was trying to do in his original paste. I thought he was just merging the testing extras together into a single array.

@stevepiercy
Copy link
Member Author

My intent was to copy what we did in the scaffolds to Pyramid's setup.py, specifically merge testing extras into a single array and use py.test instead of nose, as my proposal above reflects.

As I understand the situation, neither is desired by the core team at this time, so I reverted setup.py to its original state.

@stevepiercy
Copy link
Member Author

Closed by #2492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants