request_param in @view_config should support tuples #465

Closed
endophage opened this Issue Mar 8, 2012 · 3 comments

Projects

None yet

3 participants

@endophage

request_param should support tuples just as match_param does. Among other things, this would be very useful for oauth where multiple parameters are required to be present for a valid request.

@rpatterson
Contributor

I'm tackling this one, but I can't assign myself. Go ahead and assign to me if someone wants to.

Here's the context mcdonc gave me in #pyramid:

mcdonc_: it's what happens when you do
mcdonc_: config.add_view(request_param='foo=bar')
mcdonc_: desirable to be able to do
mcdonc_: config.add_view(request_param=('foo=bar', 'biz=baz'))
mcdonc_: the code is in pyramid/config/views.py and likely pyramid/config/util.py
mcdonc_: all the zopey stuff is in pyramid/config.. discriminators and conflict resolution and so on

@rpatterson rpatterson added a commit to rpatterson/pyramid that referenced this issue Mar 15, 2012
@rpatterson rpatterson Naive copy and paste test for request_param tuples for #465 4d37247
@rpatterson
Contributor

I've got a very preliminary attempt at generalizing the match_param handling and using it for both that and request_param:

https://github.com/rpatterson/pyramid

The existing tests and two new tests I just copied and adjusted very naively are all passing but I really need to learn what this stuff is for and write more comprehensive tests. But for now I need to switch to http://bugs.repoze.org/issue177

@rpatterson rpatterson added a commit to rpatterson/pyramid that referenced this issue Mar 15, 2012
@rpatterson rpatterson Add coverage for predicate `__text__` with params with values and
multiple params.  For Pylons/pyramid#465.
2beeac0
@mcdonc
Member
mcdonc commented Oct 13, 2012

Fixed via pull #705

@mcdonc mcdonc closed this Oct 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment