migrate pyramid_debugtoolbar imports from pyramid.mako_templating > pyramid_mako #477

Closed
reedobrien opened this Issue Mar 13, 2012 · 6 comments

Projects

None yet

4 participants

@reedobrien
Member

debugtoolbar expects mako to be in pyramid but should import it from pyramid_mako in the future.

@blaflamme
Member

want to do all templating with string interpolation ;) We really need a template engine here, I have switched the original from jinja2 to mako a few months ago.

@reedobrien
Member

sorry Blaise I don't mean without a template compiler in debugtoolbar. I mean if we remove mako and chameleon from pyramid then we need to do more than: pyramid.includes = pyramid_debugtoolbar we will need:

pyramid.includes = 
    pyramid_debugtoolbar
    pyramid_mako

in the scaffolds or some other way...or something

@blaflamme
Member

sorry... my bad... yes we should add the dependency in the scaffold ini and setup.py file

@mcdonc
Member
mcdonc commented Mar 13, 2012

I'm thinking that pyramid_mako should work via an include with 1.2 and 1.3, and basically "do no harm" (hopefully it won't conflict). That should make it pretty easy to satisfy the toolbar's dependency on pyramid_mako without needing two separate versions of the toolbar.

@mcdonc
Member
mcdonc commented Mar 13, 2012

And rather than:

pyramid.includes = 
    pyramid_debugtoolbar
    pyramid_mako

I think it'd just be:

pyramid.includes = 
    pyramid_debugtoolbar

And the includeme of pyramid_debugtoolbar will go ahead and rely on creating its own mako renderer, like it does now, but import the stuff from pyramid_mako rather than from pyramid.mako_templating.

@mmerickel
Member

Yup, pyramid_debugtoolbar includes pyramid_mako directly now so this shouldn't be a problem.

@mmerickel mmerickel closed this May 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment