Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alchemy Scaffold View Test Coverage #1029

Merged
merged 2 commits into from Aug 10, 2013

Conversation

Projects
None yet
5 participants
@junaidali
Copy link
Contributor

commented Jun 4, 2013

Hello,
I have updated the template view created by alchemy scaffold. Added new test to cover the view condition where database is not initialized. This should render the error view with status code 500.
Now the test coverage is 100% for the views.

Thanks.
Junaid.

@tseaver

This comment has been minimized.

Copy link
Member

commented Jun 18, 2013

+1

1 similar comment
@robsonpeixoto

This comment has been minimized.

Copy link

commented Jun 29, 2013

+1

@mcdonc

This comment has been minimized.

Copy link
Member

commented Jun 29, 2013

Are those test dependencies actually required by the tests that were added?

@rweir

This comment has been minimized.

Copy link

commented Aug 3, 2013

they are not.

@mcdonc mcdonc merged commit da5a402 into Pylons:master Aug 10, 2013

@mcdonc

This comment has been minimized.

Copy link
Member

commented Aug 10, 2013

Thank you, this is merged! Would you mind adding your name to the CONTRIBUTORS.txt file in a separate pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.