New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on Windows #2520

Merged
merged 2 commits into from Apr 20, 2016

Conversation

Projects
None yet
2 participants
@Cito
Contributor

Cito commented Apr 19, 2016

Two tests do not pass under Windows where backslashes instead of slashes are used in file paths. This fix makes the tests platform independent.

@Cito

This comment has been minimized.

Contributor

Cito commented Apr 19, 2016

Actually wanted to push a fix for the issue with int ports in session.py but it was already fixed 👍

@mmerickel

This comment has been minimized.

Member

mmerickel commented Apr 19, 2016

Thanks, I need to look into configuring appveyor to get our test suite running on windows. This will serve as a good reminder.

@mmerickel mmerickel merged commit 4e6f989 into Pylons:master Apr 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mmerickel

This comment has been minimized.

Member

mmerickel commented Apr 20, 2016

Cool, I got appveyor setup and tests pass. Thank you!

mmerickel added a commit that referenced this pull request Apr 20, 2016

@Cito Cito deleted the Cito:fix_tests_on_windows branch Apr 20, 2016

@Cito

This comment has been minimized.

Contributor

Cito commented Apr 20, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment