Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripping daemonization out of pserve #2615

Merged
merged 4 commits into from Jun 3, 2016

Conversation

Projects
None yet
4 participants
@zrayn
Copy link
Contributor

commented Jun 2, 2016

No description provided.

@bertjwregeer

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

Awesome!

@mmerickel

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

This looks great! Can you also pull out the user/group code from change_user_group?

@zrayn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2016

done

@mcdonc

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

Woot. LGTM. Could you add a note to CHANGES.txt about the impact of this feature? Something that describes each of the command-line options that were removed, and a general suggestion to use a "real" process manager again?

@mcdonc

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

Also, if you haven't already done so, @zrayne, can you add your name to CONTRIBUTORS.txt?

@mcdonc

This comment has been minimized.

Copy link
Member

commented Jun 2, 2016

Great.

I think if you merge master back to your branch, we'd be ready to merge this.

@zrayn

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2016

CHANGES updated and merge conflicts resolved

@mmerickel mmerickel merged commit 4e77a52 into Pylons:master Jun 3, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mmerickel added a commit that referenced this pull request Sep 1, 2016

@pyup-bot pyup-bot referenced this pull request Sep 29, 2017

Merged

Initial Update #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.