Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cachebust_match #2681

Merged
merged 1 commit into from Nov 16, 2016

Conversation

Projects
None yet
2 participants
@bertjwregeer
Copy link
Member

commented Jul 5, 2016

It was leftover from when this feature was removed in the 1.6 release cycle

Remove cachebust_match
It was leftover from when this feature was removed in the 1.6 release cycle
@mmerickel

This comment has been minimized.

Copy link
Member

commented Jul 5, 2016

I'm not sure yet whether we should remove this or document it and expose it via add_static_view. It is a possible escape hatch for someone to supply their own resolver to deal with cachebusted urls.

@bertjwregeer

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2016

I'm a -0 on that. I don't think it's a good idea.

@mmerickel mmerickel merged commit b1a4a24 into master Nov 16, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mmerickel mmerickel deleted the cleanup/cachebust_match branch Nov 16, 2016

mmerickel added a commit that referenced this pull request Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.