Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the deprecated IContextURL #2822

Merged
merged 1 commit into from Dec 15, 2016

Conversation

Projects
None yet
2 participants
@mmerickel
Copy link
Member

commented Nov 19, 2016

This PR drops support for the IContextURL interface that was deprecated in 1.3. The only part that was pretty confusing for me was the reimplementation of pyramid.traversal.virtual_root which seems somewhat different than before. It no longer consults the registered IResourceURL object for the given resource and thus the root is not configurable. I really have no idea if this is okay.

It'd be really great if @mcdonc could review this considering he originally deprecated this interface and probably understands the purpose of the API much better than I.

@mmerickel mmerickel force-pushed the mmerickel:remove-deprecated-icontexturl branch from 3bc1745 to b1e4b7f Nov 19, 2016

@mmerickel mmerickel force-pushed the mmerickel:remove-deprecated-icontexturl branch from b1e4b7f to 07a6e64 Nov 20, 2016

@mmerickel mmerickel force-pushed the mmerickel:remove-deprecated-icontexturl branch from 07a6e64 to 7ba9075 Nov 22, 2016

@mmerickel

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2016

Updated this with an attempt at using virtual_path and physical_path from the custom IResourceURL for an object in order to find the virtual root. I think this probably works.

@mmerickel mmerickel added needs-review and removed do-not-merge labels Dec 8, 2016

@bertjwregeer

This comment has been minimized.

Copy link
Member

commented Dec 15, 2016

I am not as familiar with this part of the code base. From just a discerning eye and looking over the logic, it looks good to me.

@bertjwregeer bertjwregeer merged commit 01c3afa into Pylons:master Dec 15, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

bertjwregeer added a commit that referenced this pull request Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.