Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: streaming exceptions #2863

Merged
merged 2 commits into from Dec 10, 2016

Conversation

Projects
None yet
2 participants
@bertjwregeer
Copy link
Member

commented Dec 10, 2016

Bugfix for #2625

bertjwregeer added some commits Dec 10, 2016

Use has_body so we don't unravel app_iter
This allows streaming responses.

Closes #2625
Pin to a newer version of WebOb
v1.7.0 has property Response.has_body

@bertjwregeer bertjwregeer requested a review from mmerickel Dec 10, 2016

@bertjwregeer bertjwregeer self-assigned this Dec 10, 2016

@bertjwregeer bertjwregeer added this to the 1.8 milestone Dec 10, 2016

@mmerickel mmerickel added merge-ready and removed needs-review labels Dec 10, 2016

@mmerickel mmerickel merged commit 59aa88c into master Dec 10, 2016

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@mmerickel mmerickel deleted the bugfix/streaming_exceptions branch Dec 10, 2016

mmerickel added a commit that referenced this pull request Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.