New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update comment to align with method #3171

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
2 participants
@stevepiercy
Member

stevepiercy commented Sep 23, 2017

see #3165

@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Sep 23, 2017

Member

The build is failing for pypy on Travis, and has been failing since @tseaver merged #3168. These changes are trivial docstrings or docs. I'm not sure whether this is something in zope.interface, pypy, or something else that recently changed. I checked both of their changelogs, but didn't see anything obvious. Anyone got an idea?

Member

stevepiercy commented Sep 23, 2017

The build is failing for pypy on Travis, and has been failing since @tseaver merged #3168. These changes are trivial docstrings or docs. I'm not sure whether this is something in zope.interface, pypy, or something else that recently changed. I checked both of their changelogs, but didn't see anything obvious. Anyone got an idea?

stevepiercy added a commit to stevepiercy/pyramid that referenced this pull request Sep 23, 2017

stevepiercy added a commit to stevepiercy/pyramid that referenced this pull request Sep 23, 2017

use pyramid.compat.escape instead of cgi.escape
- backport of #3165 and #3171

(cherry picked from commit e0eda61)
@tseaver

This comment has been minimized.

Show comment
Hide comment
@tseaver

tseaver Sep 23, 2017

Member

The build is failing for pypy on Travis, and has been failing since @tseaver merged #3168.

The good news is, I can reproduce the failure locally. The bad news is, I have no earthly idea what could be causing it.

Member

tseaver commented Sep 23, 2017

The build is failing for pypy on Travis, and has been failing since @tseaver merged #3168.

The good news is, I can reproduce the failure locally. The bad news is, I have no earthly idea what could be causing it.

@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Sep 23, 2017

Member

I verified that it downloads and installs pypy2.7-5.8.0 (latest on 2.7) for Ubuntu 14.04.

The last good build used pypy-2.5.0.

I'm going to ignore the build failure and merge these PRs.

I recall that we have run into issues before where Travis grabs a version of Python or pypy that causes build failures. In #pyramid on IRC, Rotonen suggested an option to work around it:

stevepie_: https://github.com/plone/plone.intelligenttext/... <- travis has kinks with how they roll out pypy so grabbing it via pyenv is a decent way around any ensuing flak

We could also report an issue at pypy, although I don't know exactly what I should report. The issue has something to do with the implementation of pop. Here's one of the two failed tests traceback (both have similar error messages):

ERROR: test_instance_conforms (pyramid.tests.test_events.TestBeforeRender)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/Pylons/pyramid/pyramid/tests/test_events.py", line 242, in test_instance_conforms
    verifyObject(IBeforeRender, event)
  File "/home/travis/build/Pylons/pyramid/.tox/pypy/site-packages/zope/interface/verify.py", line 105, in verifyObject
    return _verify(iface, candidate, tentative, vtype='o')
  File "/home/travis/build/Pylons/pyramid/.tox/pypy/site-packages/zope/interface/verify.py", line 97, in _verify
    raise BrokenMethodImplementation(name, mess)
BrokenMethodImplementation: The implementation of pop violates its contract
        because implementation requires too many arguments.

FWIW, there is a mention of fixing a pop bug in the pypy change history.

Bug Fixes
Correctly handle dict.pop where the popping key is not the same type as the dict’s and pop is called with a default (Part of the 5.7.1 bugfix release)

Member

stevepiercy commented Sep 23, 2017

I verified that it downloads and installs pypy2.7-5.8.0 (latest on 2.7) for Ubuntu 14.04.

The last good build used pypy-2.5.0.

I'm going to ignore the build failure and merge these PRs.

I recall that we have run into issues before where Travis grabs a version of Python or pypy that causes build failures. In #pyramid on IRC, Rotonen suggested an option to work around it:

stevepie_: https://github.com/plone/plone.intelligenttext/... <- travis has kinks with how they roll out pypy so grabbing it via pyenv is a decent way around any ensuing flak

We could also report an issue at pypy, although I don't know exactly what I should report. The issue has something to do with the implementation of pop. Here's one of the two failed tests traceback (both have similar error messages):

ERROR: test_instance_conforms (pyramid.tests.test_events.TestBeforeRender)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/Pylons/pyramid/pyramid/tests/test_events.py", line 242, in test_instance_conforms
    verifyObject(IBeforeRender, event)
  File "/home/travis/build/Pylons/pyramid/.tox/pypy/site-packages/zope/interface/verify.py", line 105, in verifyObject
    return _verify(iface, candidate, tentative, vtype='o')
  File "/home/travis/build/Pylons/pyramid/.tox/pypy/site-packages/zope/interface/verify.py", line 97, in _verify
    raise BrokenMethodImplementation(name, mess)
BrokenMethodImplementation: The implementation of pop violates its contract
        because implementation requires too many arguments.

FWIW, there is a mention of fixing a pop bug in the pypy change history.

Bug Fixes
Correctly handle dict.pop where the popping key is not the same type as the dict’s and pop is called with a default (Part of the 5.7.1 bugfix release)

@stevepiercy stevepiercy merged commit dba0b43 into Pylons:master Sep 23, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment