New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1736 add forms and validation tests #3375

Merged
merged 2 commits into from Oct 6, 2018

Conversation

Projects
None yet
3 participants
@WilliamTakeshi
Contributor

WilliamTakeshi commented Oct 6, 2018

No description provided.

@stevepiercy

This comment has been minimized.

Show comment
Hide comment
@stevepiercy

stevepiercy Oct 6, 2018

Member

I ran the tests successfully with warnings:

============================================================================================================== warnings summary ===============================================================================================================
/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/headers.py:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import MutableMapping

/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webtest/lint.py:201: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  assert isinstance(iterator, collections.Iterable), (

/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:1088: DeprecationWarning: The MIMEAccept class has been replaced by webob.acceptparse.create_accept_header. This compatibility shim will be deprecated in a future version of WebOb.
  DeprecationWarning
/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:972: DeprecationWarning: The behavior of AcceptValidHeader.best_match is currently being maintained for backward compatibility, but it will be deprecated in the future, as it does not conform to the RFC.
  DeprecationWarning,

/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:1088: DeprecationWarning: The MIMEAccept class has been replaced by webob.acceptparse.create_accept_header. This compatibility shim will be deprecated in a future version of WebOb.
  DeprecationWarning
/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:972: DeprecationWarning: The behavior of AcceptValidHeader.best_match is currently being maintained for backward compatibility, but it will be deprecated in the future, as it does not conform to the RFC.
  DeprecationWarning,

-- Docs: https://docs.pytest.org/en/latest/warnings.html
6 passed, 6 warnings in 0.72 seconds

I'm OK with merging this PR, but I think it would be good to report the warnings as a new issue in the appropriate libraries (pyramid.testing, webtest, other?).

Member

stevepiercy commented Oct 6, 2018

I ran the tests successfully with warnings:

============================================================================================================== warnings summary ===============================================================================================================
/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/headers.py:1: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import MutableMapping

/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webtest/lint.py:201: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  assert isinstance(iterator, collections.Iterable), (

/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:1088: DeprecationWarning: The MIMEAccept class has been replaced by webob.acceptparse.create_accept_header. This compatibility shim will be deprecated in a future version of WebOb.
  DeprecationWarning
/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:972: DeprecationWarning: The behavior of AcceptValidHeader.best_match is currently being maintained for backward compatibility, but it will be deprecated in the future, as it does not conform to the RFC.
  DeprecationWarning,

/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:1088: DeprecationWarning: The MIMEAccept class has been replaced by webob.acceptparse.create_accept_header. This compatibility shim will be deprecated in a future version of WebOb.
  DeprecationWarning
/Users/stevepiercy/projects/hack-on-pyramid/forms/env/lib/python3.7/site-packages/webob/acceptparse.py:972: DeprecationWarning: The behavior of AcceptValidHeader.best_match is currently being maintained for backward compatibility, but it will be deprecated in the future, as it does not conform to the RFC.
  DeprecationWarning,

-- Docs: https://docs.pytest.org/en/latest/warnings.html
6 passed, 6 warnings in 0.72 seconds

I'm OK with merging this PR, but I think it would be good to report the warnings as a new issue in the appropriate libraries (pyramid.testing, webtest, other?).

@stevepiercy stevepiercy requested a review from mmerickel Oct 6, 2018

@mmerickel

This comment has been minimized.

Show comment
Hide comment
@mmerickel

mmerickel Oct 6, 2018

Member

The warnings are from webob, webtest and pyramid. I submitted Pylons/webob#377 to fix one of the webob warnings. #3326 fixes most of the others. Finally webtest has a remaining warning that someone could fix if they wished, but it has nothing to do with pyramid.

Member

mmerickel commented Oct 6, 2018

The warnings are from webob, webtest and pyramid. I submitted Pylons/webob#377 to fix one of the webob warnings. #3326 fixes most of the others. Finally webtest has a remaining warning that someone could fix if they wished, but it has nothing to do with pyramid.

@mmerickel mmerickel merged commit 07b0037 into Pylons:master Oct 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mmerickel added a commit that referenced this pull request Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment