New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed principals_allowed_by_permission to act differently if permissive is True or False #3442

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@Estartu
Copy link
Contributor

Estartu commented Dec 26, 2018

principals_allowed_by_permission of the DummySecurityPolicy should return an empty list if permissive is set to False as no Principal is allowed

Estartu added some commits Nov 11, 2018

principals_allowed_by_permission returned all principals regardless i…
…f permissiv is true or false. It should return a empty list if permissive is False.
principals_allowed_by_permission is described to always return a sequ…
…ence. Most of the time the result is used with something like Everyone in principals_allowed_by_permission or iterated over. So even if no prinicpal is authorised it should be a sequence regardless.

@Estartu Estartu force-pushed the Estartu:master branch from ad4d2c2 to 2d091dc Dec 26, 2018

@mmerickel

This comment has been minimized.

Copy link
Member

mmerickel commented Dec 26, 2018

Thanks! I'm leaving this open until we backport this to 1.10-branch as I consider it a bug fix.

mmerickel added a commit to mmerickel/pyramid that referenced this pull request Jan 5, 2019

backport Pylons#3442 to 1.10-branch
principals_allowed_by_permission returned all principals regardless
if permissiv is true or false. It should return a empty list if
permissive is False.

mmerickel added a commit to mmerickel/pyramid that referenced this pull request Jan 5, 2019

backport Pylons#3442 to 1.9-branch
principals_allowed_by_permission returned all principals regardless
if permissiv is true or false. It should return a empty list if
permissive is False.

@mmerickel mmerickel merged commit 7bd9da7 into Pylons:master Jan 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mmerickel added a commit that referenced this pull request Jan 11, 2019

mmerickel added a commit that referenced this pull request Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment