Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 1.10: fix imp deprecation #3659

Merged

Conversation

leorochael
Copy link

This is affecting the 1.10 branch today.

@leorochael leorochael force-pushed the 1.10-backport-imp-deprecation-fix branch 3 times, most recently from ce08803 to 236c80c Compare February 24, 2021 16:13
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint build failed due to an extra space

src/pyramid/path.py Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Member

@leorochael would you please sign CONTRIBUTORS.txt, and push that commit? Thank you!

@leorochael
Copy link
Author

@leorochael would you please sign CONTRIBUTORS.txt, and push that commit? Thank you!

I was hoping not to have to do that since at first I just backported @mmerickel's commit to another branch.

But I guess I added enough new code to be able to stradle old and new Python versions, so I'll add myself.

@leorochael leorochael force-pushed the 1.10-backport-imp-deprecation-fix branch from 1b3cfe5 to 6d22d60 Compare February 25, 2021 16:42
Co-authored-with: Leonardo Rochael Almeida <leorochael@gmail.com>
Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leorochael
Copy link
Author

@stevepiercy, thank you for your review and approval.

What are the next steps for inclusion and new point release of the 1.10 branch?

@stevepiercy
Copy link
Member

@mmerickel is release manager, and he should review this PR, too.

Assuming he approves, he mentioned last weekend that a Pyramid 2.0 final release would come within a week. I assume he will conduct a release party soon in which the 1.10-branch will be a celebrated honoree.

@mmerickel
Copy link
Member

@leorochael LGTM - Could you please add a changelog entry for this bugfix? Thank you!

@mmerickel mmerickel merged commit 37a8e3e into Pylons:1.10-branch Mar 1, 2021
@leorochael
Copy link
Author

@mmerickel, sorry I couldn't get to it this weekend.

Thanks for merging and adding the changelog!

@mmerickel
Copy link
Member

No worries, I just ask out of laziness. :-) Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants