New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport to 1.10: fix imp deprecation #3659
Backport to 1.10: fix imp deprecation #3659
Conversation
ce08803
to
236c80c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lint build failed due to an extra space
@leorochael would you please sign CONTRIBUTORS.txt, and push that commit? Thank you! |
I was hoping not to have to do that since at first I just backported @mmerickel's commit to another branch. But I guess I added enough new code to be able to stradle old and new Python versions, so I'll add myself. |
1b3cfe5
to
6d22d60
Compare
Co-authored-with: Leonardo Rochael Almeida <leorochael@gmail.com>
6d22d60
to
1ecfab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@stevepiercy, thank you for your review and approval. What are the next steps for inclusion and new point release of the 1.10 branch? |
@mmerickel is release manager, and he should review this PR, too. Assuming he approves, he mentioned last weekend that a Pyramid 2.0 final release would come within a week. I assume he will conduct a release party soon in which the 1.10-branch will be a celebrated honoree. |
@leorochael LGTM - Could you please add a changelog entry for this bugfix? Thank you! |
@mmerickel, sorry I couldn't get to it this weekend. Thanks for merging and adding the changelog! |
No worries, I just ask out of laziness. :-) Thanks for the PR! |
This is affecting the 1.10 branch today.