Improve text of SQLAlchemy wiki tutorial. #496

Merged
merged 2 commits into from Mar 17, 2012

Conversation

Projects
None yet
2 participants
@douglatornell
Contributor

douglatornell commented Mar 17, 2012

A mixture of typo fixes and wording improvements.

Improve text of SQLAlchemy wiki tutorial.
A mixture of typo fixes and wording improvements.
@@ -322,7 +324,7 @@ each of the following URLs, check that the result is as expected:
- ``http://localhost:6543/FrontPage`` invokes
the ``view_page`` view of the FrontPage page object.
-- ``http://localhost:6543/edit_page/FrontPage``
+- ``http://localhost:6543/FrontPage/edit_page``

This comment has been minimized.

Show comment Hide comment
@douglatornell

douglatornell Mar 17, 2012

Contributor

I changed this to be consistent with the rest of the tutorial, but I wonder if both the text and the code should be changed to http://localhost:6543/edit_page/FrontPage so that the edit page URL has the same {action}/{subject} form as the add page URL.

@douglatornell

douglatornell Mar 17, 2012

Contributor

I changed this to be consistent with the rest of the tutorial, but I wonder if both the text and the code should be changed to http://localhost:6543/edit_page/FrontPage so that the edit page URL has the same {action}/{subject} form as the add page URL.

This comment has been minimized.

Show comment Hide comment
@mcdonc

mcdonc Mar 17, 2012

Member

Good catch here; I agree it would be better if they had the same ordering eventually.

@mcdonc

mcdonc Mar 17, 2012

Member

Good catch here; I agree it would be better if they had the same ordering eventually.

@douglatornell

This comment has been minimized.

Show comment Hide comment
@douglatornell

douglatornell Mar 17, 2012

Contributor

I feel like tests.rst could benefit from some explanation of the tests to supplement the big blob of code, but I'll leave that for another day.

Contributor

douglatornell commented Mar 17, 2012

I feel like tests.rst could benefit from some explanation of the tests to supplement the big blob of code, but I'll leave that for another day.

mcdonc added a commit that referenced this pull request Mar 17, 2012

Merge pull request #496 from douglatornell/sql-tut-edits
Improve text of SQLAlchemy wiki tutorial.

@mcdonc mcdonc merged commit fca8f01 into Pylons:master Mar 17, 2012

@mcdonc

This comment has been minimized.

Show comment Hide comment
@mcdonc

mcdonc Mar 17, 2012

Member

Great changes, thanks a lot Doug!

Member

mcdonc commented Mar 17, 2012

Great changes, thanks a lot Doug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment