Set custom request properties in pyramid.scripting (issue #520) #538

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@dairiki
Contributor
dairiki commented Apr 17, 2012

Bump: This is the commit referenced in #520 rebased onto the current head (and formulated as a pull request to garner more attention.)

@mmerickel
Member

crap I actually tried to find this issue when I was toying with the request properties

I will try to think about it tonight

@mmerickel
Member

We added support for config.set_request_method which handles methods as well as properties. Looking at this diff I do not think it will work for methods in its current form. Shouldn't be a tough fix though.

@dairiki
Contributor
dairiki commented Apr 20, 2012

Okay, feeling stupid here. I’m not able to find anything about config.set_request_method. (I’ve just grepped the master branch.) Can you give me a pointer?

@mmerickel
Member

Apologies, I didn't realize I hadn't merged it yet. It will be going in soon though.

mmerickel@master...feature.instance-properties

@dairiki
Contributor
dairiki commented Apr 20, 2012

Aha. Well, let me know if/when you want me to do anything on this.

(If it's allowable to use .config.factories._set_request_extensions() from .scripting._make_request(), the adjustment is trivial.)

@mcdonc mcdonc added a commit that referenced this pull request Sep 11, 2012
@mcdonc mcdonc - Request properties and methods added via ``config.set_request_prope…
…rty`` or

  ``config.add_request_method`` are now available to tweens.

- Request properties and methods added via ``config.set_request_property`` or
  ``config.add_request_method`` are now available in the request object
  returned from ``pyramid.paster.bootstrap``.

Related partially to issue #520 and issue #538 and issue #596, although it doesn't actually allow us to close any of them, because we still don't issue a newrequest event when bootstrap is used.
7359873
@mmerickel
Member

This has been fixed in 7359873 and released in 1.4a1.

@mmerickel mmerickel closed this Nov 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment