Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

preliminary fix for refactorings from 4d2602ce #727

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

witsch commented Nov 16, 2012

with the change from __text__ to text() the code putting together the output used when debug_routematch is set was broken. it still uses .__text__. the same is true for the pviews script. however, simply changing things to use .text() breaks test_views_command_single_view_route_with_route_predicates and i'm not sure if the function used for a predicate there can be changed into a class, or if function predicates should still be supported...

preliminary fix for refactorings from 4d2602c
with the change from `__text__` to `text()` the code putting together the output used when `debug_routematch` is set was broken.  it still uses `.__text__`.  the same is true for the `pviews` script.  however, simply changing things to use `.text()` breaks `test_views_command_single_view_route_with_route_predicates` and i'm not sure if the function used for a predicate there can be changed into a class, or if function predicates should still be supported...

@mcdonc mcdonc closed this in 0ccdc23 Nov 19, 2012

Owner

mcdonc commented Nov 19, 2012

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment