Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Toolbar does not work with Dojo #80

Closed
Cito opened this Issue Nov 9, 2012 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

Cito commented Nov 9, 2012

Unfortunately, the pyramid_debugtoolbar does not work with Pyramid applications which are using Dojo. The reason is that Dojo comes with its own implementation of require which is incompatible with require.js used by pyramid_debugtoolbar.

I think this should be fixed by removing require.js from pyramid_debugtoolbar, I think it does more harm than good. The toolbar should just use jquery directly, and make use of jQuery.noConflict.

Owner

blaflamme commented Nov 9, 2012

On some browsers, like chrome, even with the noConflict and/or reassignment it appears sometime the wrong version is used and also cause problems. Until we find a better solution we'll stick with that, or if you have a patch that fix the problem globally (not just for dojo) I'll be more than happy to apply it. OTOH 'm looking at removing the toolbar from the page and make it run in standalone mode, so it'll remove that problem and won't pollute the current html too.

Contributor

Cito commented Nov 9, 2012

Ok, so I have created a simple patch that makes the debug toolbar use a patched version of require.js with a distinct private name that cannot clash with the dojo loader or other incompatible incarnations of require that may already be loaded on the page. It's not elegant, but it works for me.

Owner

blaflamme commented Nov 29, 2012

Applied your fix, thanks!

@blaflamme blaflamme closed this Nov 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment